[sr-dev] [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[sr-dev] [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

Victor Seva-3

I'm having issues when I reach EVAPI_MAX_CLIENTS connections but some of them are just lingering and they are never release, so no new connections can be handled.

Maybe keepalive will help detecting those lingering connections and release them


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"evapi: add module parameter to enable keepalive (#1290)"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1290"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

Victor Seva-3

I went and added this in order to allow coping in such situations, being a limitation in some operation cases, it needed to be fixed somehow.

On the other hand, while doing it, I noticed that a close was missing, so it could have been a reason for some connections to stay longer in open state, but it should have not affected the number of client structure, only file descriptors.

I also enabled tcp keepalive on client connections with another commit.

Testing, especially if max_clients doesn't break things, would be appreciated.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1290: I went and added this in order to allow coping in such situations, being a limitation in some operation cases, it needed to be fixed somehow.\r\n\r\nOn the other hand, while doing it, I noticed that a close was missing, so it could have been a reason for some connections to stay longer in open state, but it should have not affected the number of client structure, only file descriptors.\r\n\r\nI also enabled tcp keepalive on client connections with another commit.\r\n\r\nTesting, especially if max_clients doesn't break things, would be appreciated."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1290#issuecomment-341643841"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

Victor Seva-3
In reply to this post by Victor Seva-3

Closed #1290.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #1290."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1290#event-1324442695"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

Victor Seva-3
In reply to this post by Victor Seva-3

Can I backport 95bd694 bb91d6c d340582 to 5.0?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@linuxmaniac in #1290: Can I backport 95bd694e75c250d8b26cac071bff2e48e0eb9062 bb91d6c4fa88324c31d3b7a91687057e0ae8bfa0 d340582267174ccb0a5d816049c582fe75d2177b to 5.0?"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1290#issuecomment-347843552"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] evapi: add module parameter to enable keepalive (#1290)

Victor Seva-3
In reply to this post by Victor Seva-3

ok


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1290: ok"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1290#issuecomment-347849756"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev